Daniel Cazzulino's Blog

Go Back to
kzu′s Latest post

Improving MoQ to allow arrange-act-assert testing style

Today, the MoQAPI lets you setup expectations and later verify them, like so:

public void FillingRemovesInventoryIfInStock()
    var order = new Order(TALISKER, 50);
    var mock = new Mock<IWarehouse>();

    //setup - expectations
    mock.Expect(x => x.HasInventory(TALISKER, 50)).Returns(true);

    //verify interaction

A very good feedback I got during the past MVP Summit was that the current approach moves all the semantic relevance for mocks up to the setup phase of the test. In order words, it doesn’t fit well in the Arrange-Act-Assert pattern, as effectively the “asserts” (expectations that must be met) are now in the “arrange” (or setup) phase of the test.

The Verify/VerifyAll call which is down at the assertion phase contains no semantic whatsoever about what it is you are expecting to happen.

In order to be accomodate this requirement, I’m gonna be adding a overload to Verify that takes the expression you want to verify:

mock.Verify(x => x.HasInventory(TALISKER, 50));

This would bring back the assertion phase to the place it belongs, if that’s what you need. And because the default behavior on MoQ mocks is that they never throw on unexpected invocations, you can use the Expect only to setup return values when you need them (I’m hesitant to rename Expect to Setup, as for people using strict mocks that prefer the VerifyAll approach, it won’t make much sense).


What do you think?